Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip: Update the component markup for a11y remediations & refactor the existing styles towards more static styling #3032

Merged
merged 38 commits into from
Apr 11, 2023
Merged

Tooltip: Update the component markup for a11y remediations & refactor the existing styles towards more static styling #3032

merged 38 commits into from
Apr 11, 2023

Commits on Mar 15, 2023

  1. Refactor tooltip markup without styled components and apply a11y reme… 

    …diations
    @broccolinisoup
    broccolinisoup committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    4efc95d View commit details
    Browse the repository at this point in the history

  2. experiment tooltip

    @broccolinisoup
    broccolinisoup committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    e2b140b View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. checking interactive elements and clean the code a bit

    @broccolinisoup
    broccolinisoup committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    84d93eb View commit details
    Browse the repository at this point in the history

  2. add another story

    @broccolinisoup
    broccolinisoup committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    842f50e View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. style fixes and more stories

    @broccolinisoup
    broccolinisoup committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    f052247 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into tooltip-experiments

    @broccolinisoup
    broccolinisoup committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    5f25911 View commit details
    Browse the repository at this point in the history

  3. refactor it to use internal open state and make css presudo classes r… 

    …edundant
    @broccolinisoup
    broccolinisoup committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    fff246f View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. apply code review feedback

    @broccolinisoup
    broccolinisoup committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    16a8258 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Merge branch 'main' into tooltip-experiments

    @broccolinisoup
    broccolinisoup authored Mar 22, 2023
    Configuration menu
    Copy the full SHA
    b6ea709 View commit details
    Browse the repository at this point in the history

  2. Refactor the styles to use data-attr and styled-components

    @broccolinisoup
    broccolinisoup committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    8be4e6c View commit details
    Browse the repository at this point in the history

  3. update events

    @broccolinisoup
    broccolinisoup committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    03a081a View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. align and wrap styles with data attr

    @broccolinisoup
    broccolinisoup committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    55d5f0f View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. remove unused var

    @broccolinisoup
    broccolinisoup committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    2096001 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. restructure markup and make tooltip hoverable

    @broccolinisoup
    broccolinisoup committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    a1f908f View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. wrap up, clean up, interactive children

    @broccolinisoup
    broccolinisoup committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    2587269 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Josh Black <joshblack@github.com>
    @broccolinisoup @joshblack
    broccolinisoup and joshblack authored Mar 29, 2023
    Configuration menu
    Copy the full SHA
    dff06a9 View commit details
    Browse the repository at this point in the history

  2. code review feedback

    @broccolinisoup
    broccolinisoup committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    2e9e18c View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Merge branch 'main' into tooltip-experiments

    @broccolinisoup
    broccolinisoup committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    407398c View commit details
    Browse the repository at this point in the history

  2. add outline for force-color media

    @broccolinisoup
    broccolinisoup committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    da1bc70 View commit details
    Browse the repository at this point in the history

  3. Add unit tests

    @broccolinisoup
    broccolinisoup committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    f3116bb View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Merge branch 'main' into tooltip-experiments

    @broccolinisoup
    broccolinisoup committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    ec8e0ea View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. check the trigger element's content for label

    @broccolinisoup
    broccolinisoup committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    8e83bb6 View commit details
    Browse the repository at this point in the history

  2. useOnEscapePress hook to close the tooltip when mouse is hovering ove… 

    …r the trigger element
    @broccolinisoup
    broccolinisoup committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d5077cb View commit details
    Browse the repository at this point in the history

  3. fix tests

    @broccolinisoup
    broccolinisoup committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d2400d4 View commit details
    Browse the repository at this point in the history

  4. docs and move tooltip into folder

    @broccolinisoup
    broccolinisoup committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    dd7da3b View commit details
    Browse the repository at this point in the history

  5. Update generated/components.json

    @broccolinisoup @github-actions
    broccolinisoup authored and github-actions[bot] committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    87df7b5 View commit details
    Browse the repository at this point in the history

  6. add changeset

    @broccolinisoup
    broccolinisoup committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    1a3a456 View commit details
    Browse the repository at this point in the history

  7. fix imports

    @broccolinisoup
    broccolinisoup committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    16fc7b1 View commit details
    Browse the repository at this point in the history

  8. update snapshot

    @broccolinisoup
    broccolinisoup committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c7dd301 View commit details
    Browse the repository at this point in the history

  9. update snapshot

    @broccolinisoup
    broccolinisoup committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    3f1917f View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into tooltip-experiments

    @broccolinisoup
    broccolinisoup authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    7863594 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Merge branch 'main' into tooltip-experiments

    @broccolinisoup
    broccolinisoup authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    c5597f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Merge branch 'main' into tooltip-experiments

    @broccolinisoup
    broccolinisoup committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a7797a9 View commit details
    Browse the repository at this point in the history

  2. default value to the docs

    @broccolinisoup
    broccolinisoup committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    5861cac View commit details
    Browse the repository at this point in the history

  3. Update generated/components.json

    @broccolinisoup @github-actions
    broccolinisoup authored and github-actions[bot] committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    ca9c135 View commit details
    Browse the repository at this point in the history

  4. snaps

    @broccolinisoup
    broccolinisoup committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    2042dd7 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into tooltip-experiments

    @broccolinisoup
    broccolinisoup committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    e60a1ca View commit details
    Browse the repository at this point in the history

  6. remove snapshot tests

    @broccolinisoup
    broccolinisoup committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    7a816fb View commit details
    Browse the repository at this point in the history