Tooltip: Update the component markup for a11y remediations & refactor the existing styles towards more static styling #3032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7a816fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
changed the title
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
commented
Mar 16, 2023
broccolinisoup
commented
Mar 16, 2023
broccolinisoup
commented
Mar 16, 2023
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
changed the title
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
commented
Mar 20, 2023
broccolinisoup
commented
Mar 20, 2023
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
force-pushed
the
tooltip-experiments
branch
from
cdddec8
to
a694fbc
Compare
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
force-pushed
the
tooltip-experiments
branch
from
3fcf4b0
to
2042dd7
Compare
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Merged
This was referenced May 3, 2023
broccolinisoup
added a commit
that referenced
this pull request
May 4, 2023
… the existing styles towards more static styling (#3032) * Refactor tooltip markup without styled components and apply a11y remediations * experiment tooltip * checking interactive elements and clean the code a bit * add another story * style fixes and more stories * refactor it to use internal open state and make css presudo classes redundant * apply code review feedback * Refactor the styles to use data-attr and styled-components * update events * align and wrap styles with data attr * remove unused var * restructure markup and make tooltip hoverable * wrap up, clean up, interactive children * Apply suggestions from code review Co-authored-by: Josh Black <joshblack@github.com> * code review feedback * add outline for force-color media * Add unit tests * check the trigger element's content for label * useOnEscapePress hook to close the tooltip when mouse is hovering over the trigger element * fix tests * docs and move tooltip into folder * Update generated/components.json * add changeset * fix imports * update snapshot * update snapshot * default value to the docs * Update generated/components.json * snaps * remove snapshot tests --------- Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/1909
Closes https://github.com/github/primer/issues/1907
Closes https://github.com/github/primer/issues/1918
Storybook features: https://primer-7bad896c1f-13348165.drafts.github.io/storybook/?path=/story/components-tooltip-features--tooltip-description-type-tooltip
Docs: https://primer-7bad896c1f-13348165.drafts.github.io/Tooltip
This PR refactors the current
Tooltipcomponent to update the markup and styles to match with the expected accessibility requirements.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.