Setting overflow: auto without a media query to fix resizable pane bug. #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 26d2501 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
colebemis
reviewed
Dec 12, 2022
|
While we're here, can we add any tests to avoid regressing the resizable pane again in the future? |
colebemis
reviewed
Dec 13, 2022
colebemis
reviewed
Dec 13, 2022
Co-authored-by: Cole Bemis <colebemis@github.com>
radglob
force-pushed
the
bugfix/fix-splitpane-resizing
branch
from
1e1eb12
to
a251e0e
Compare
radglob
commented
Dec 13, 2022
Comment on lines
+196
to
+198
| fireEvent.mouseDown(divider) | ||
| fireEvent.mouseMove(divider) | ||
| fireEvent.mouseUp(divider) |
There was a problem hiding this comment.
This isn't a perfect test. I'm not sure how to configure this to move the divider a specific amount. However, as is, this does change the --pane-width value. fireEvent.click doesn't do that, so I think this is testing what we want.
Co-authored-by: Cole Bemis <colebemis@github.com>
colebemis
approved these changes
Dec 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically reverts the work in #2606. Setting
overflow: autoinside of a media query seemed to fix an issue where scrolling panes would be hard to use on mobile as you would have a scrolling container within another scrolling container. Changing this back to not use a media query seems to have the desired behavior without breaking resizable panes.Closes #2684.
Screenshots
Please provide before/after screenshots for any visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.