Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitPane resizing broken in 35.15.1 #2684

Closed
mattcosta7 opened this issue Dec 12, 2022 · 0 comments · Fixed by #2685
Closed

SplitPane resizing broken in 35.15.1 #2684

mattcosta7 opened this issue Dec 12, 2022 · 0 comments · Fixed by #2685
Assignees
@radglob
Labels
bug Something isn't working react

Comments

@mattcosta7
Copy link
Collaborator

mattcosta7 commented Dec 12, 2022 •
edited
Loading

Description

In 35.15.1 we shipped #2606 which overrides the 'overflow' to auto for the split pane view, and avoids the explict width we should be setting for resizing.

https://github.com/primer/react/pull/2606/files#diff-e4049ccb37961f4fa30e007dfb5b91b6c42dfa7cc680f0d287857577d2bf8d2fR175

Steps to reproduce

Try to resize the split pane in the latest version, notice it wont resize

Version

v35.15.1

Browser

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radglob radglob

Labels
bug Something isn't working react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Setting overflow: auto without a media query to fix resizable pane bug. primer/react
4 participants
@radglob @colebemis @mattcosta7 @primer-css