Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(project): update tests for React 18 #2673

Merged
merged 21 commits into from
Dec 15, 2022
Merged

test(project): update tests for React 18 #2673

merged 21 commits into from
Dec 15, 2022

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Dec 9, 2022 •
edited
Loading

Update test files that were failing when using React 18.

Changelog

New

Changed

  • Update ThemeProvider tests to use @testing-library/user-event
  • Add TextEncoder for useMedia tests
  • Add act() calls for tests for TextInputWithTokens and MarkdownEditor

Removed

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: e335265

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 82.79 KB (+0.05% 🔺)
dist/browser.umd.js 83.47 KB (+0.06% 🔺)

@joshblack joshblack temporarily deployed to github-pages December 9, 2022 18:36 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2673 December 9, 2022 18:37 Inactive
@joshblack joshblack force-pushed the chore/update-tests-for-react-18 branch from a58707f to e2b75b4 Compare December 9, 2022 19:53
@joshblack joshblack marked this pull request as ready for review December 9, 2022 19:53
@joshblack joshblack requested review from a team and langermank December 9, 2022 19:53
@joshblack joshblack added the skip changeset This change does not need a changelog label Dec 9, 2022
@github-actions github-actions bot temporarily deployed to storybook-preview-2673 December 9, 2022 19:55 Inactive
@joshblack joshblack temporarily deployed to github-pages December 9, 2022 19:59 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2673 December 9, 2022 19:59 Inactive
@joshblack

This comment was marked as outdated.

Sign in to view
@joshblack joshblack temporarily deployed to github-pages December 12, 2022 22:05 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2673 December 12, 2022 22:05 Inactive
@joshblack joshblack temporarily deployed to github-pages December 12, 2022 22:33 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2673 December 12, 2022 22:33 Inactive
@joshblack joshblack mentioned this pull request Dec 13, 2022
Closed
22 tasks
@joshblack joshblack temporarily deployed to github-pages December 15, 2022 18:03 — with GitHub Actions Inactive
@joshblack joshblack merged commit 9b87ecd into feat/update-types-for-react-18 Dec 15, 2022
@joshblack joshblack deleted the chore/update-tests-for-react-18 branch December 15, 2022 18:20
@joshblack joshblack mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colebemis colebemis colebemis approved these changes

@langermank langermank Awaiting requested review from langermank

Assignees
No one assigned
Labels
react skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @colebemis