-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(project): update project to use React 18 #2661
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9f25f74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
joshblack
temporarily deployed
to
github-pages
December 6, 2022 23:35
— with
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
December 6, 2022 23:46
— with
GitHub Actions
Inactive
broccolinisoup
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just left a question.
colebemis
approved these changes
Dec 13, 2022
22 tasks
joshblack
changed the title
chore(project): add script to set react version
feat(project): update project to use React 18
Dec 15, 2022
joshblack
temporarily deployed
to
github-pages
December 16, 2022 18:10
— with
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
December 16, 2022 18:23
— with
GitHub Actions
Inactive
joshblack
temporarily deployed
to
github-pages
December 16, 2022 19:18
— with
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2536
This PR is a rollup of the following PRs to update the project to use React 18 in development:
The strategy used is to test both React 17 and React 18. In the codebase, we also need to check for the presence of React 18 features before using them in order to maintain backwards compatability.