Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project): update project to use React 18 #2661

Merged
merged 37 commits into from
Dec 16, 2022
Merged

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Dec 6, 2022

Related: #2536

This PR is a rollup of the following PRs to update the project to use React 18 in development:

The strategy used is to test both React 17 and React 18. In the codebase, we also need to check for the presence of React 18 features before using them in order to maintain backwards compatability.

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2022

🦋 Changeset detected

Latest commit: 9f25f74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 84.08 KB (+0.06% 🔺)
dist/browser.umd.js 84.73 KB (+0.09% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-2661 December 6, 2022 23:32 Inactive
@joshblack joshblack temporarily deployed to github-pages December 6, 2022 23:35 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2661 December 6, 2022 23:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2661 December 6, 2022 23:37 Inactive
@joshblack joshblack added the skip changeset This change does not need a changelog label Dec 6, 2022
@joshblack joshblack temporarily deployed to github-pages December 6, 2022 23:46 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2661 December 6, 2022 23:46 Inactive
@joshblack joshblack marked this pull request as ready for review December 6, 2022 23:47
Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just left a question.

script/set-react-version.js Show resolved Hide resolved
@joshblack joshblack mentioned this pull request Dec 13, 2022
22 tasks
@joshblack joshblack changed the title chore(project): add script to set react version feat(project): update project to use React 18 Dec 15, 2022
@joshblack joshblack temporarily deployed to github-pages December 16, 2022 18:10 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2661 December 16, 2022 18:10 Inactive
@joshblack joshblack temporarily deployed to github-pages December 16, 2022 18:23 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2661 December 16, 2022 18:24 Inactive
@joshblack joshblack closed this Dec 16, 2022
@joshblack joshblack reopened this Dec 16, 2022
@joshblack joshblack removed the skip changeset This change does not need a changelog label Dec 16, 2022
@joshblack joshblack closed this Dec 16, 2022
@joshblack joshblack reopened this Dec 16, 2022
@github-actions github-actions bot temporarily deployed to storybook-preview-2661 December 16, 2022 19:13 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-2661 December 16, 2022 19:14 Inactive
@joshblack joshblack temporarily deployed to github-pages December 16, 2022 19:18 — with GitHub Actions Inactive
@joshblack joshblack merged commit 5dd4bb1 into main Dec 16, 2022
@joshblack joshblack deleted the ci/add-react-18-test branch December 16, 2022 19:41
@primer-css primer-css mentioned this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants