PageHeader: Handle responsive CSS properties with breakpoints #2662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0927bd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
force-pushed
the
pk/page-header
branch
from
a20914b
to
6629315
Compare
broccolinisoup
force-pushed
the
css-breakpoints-page-header
branch
from
68def40
to
ca2deb6
Compare
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
force-pushed
the
css-breakpoints-page-header
branch
from
4df374d
to
4987885
Compare
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
changed the title
hidden prop
broccolinisoup
requested review from
colebemis,
joshblack,
mperrotti and
siddharthkp
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
colebemis
approved these changes
Dec 19, 2022
There was a problem hiding this comment.
Looks good to go after you make the function name change 👍 Nice work on this @broccolinisoup 🎉
broccolinisoup
force-pushed
the
css-breakpoints-page-header
branch
from
99d3e7a
to
0927bd1
Compare
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
changed the title
hidden prop
Merged
colebemis
pushed a commit
that referenced
this pull request
Jan 21, 2023
* try using media query instead of hook * Update to use css media queries and make the func more generic * add comments and rename the function * update unit tests * add changeset * remove unused imports * address code review feedback * type fixes & small adj & add fallback CSS declaration * type fix and add comment * update tests * update changeset description * rename the function and move it into utils/
colebemis
pushed a commit
that referenced
this pull request
Jan 21, 2023
* try using media query instead of hook * Update to use css media queries and make the func more generic * add comments and rename the function * update unit tests * add changeset * remove unused imports * address code review feedback * type fixes & small adj & add fallback CSS declaration * type fix and add comment * update tests * update changeset description * rename the function and move it into utils/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/1569
Following up a #2265 (comment) for shifting the responsiveness logic from JS to CSS via using media queries to make the component more SSR friendly.
Context:
Currently PageHeader uses
useResponsiveHookto manage components' visibility viahiddenprop. It works fine however, this causes a layout shift in SSR. To avoid that, this PR adds a utility function calledCSSManagedResponsiveValueand it manages the responsive visibility with CSS breakpoints and still keeps the same APIor
Screenshots
No visual changes
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.