2411 the aria keyshortcuts is wrongly attached for the actionlistlinkitem components #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bd6dbc8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
…tcuts-is-wrongly-attached-for-the-actionlistlinkitem-components
…ed-for-the-actionlistlinkitem-components
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…actionlistlinkitem-components' of github.com:primer/react into 2411-the-aria-keyshortcuts-is-wrongly-attached-for-the-actionlistlinkitem-components
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…ed-for-the-actionlistlinkitem-components
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joshblack
requested review from
siddharthkp
and removed request for
siddharthkp
|
cc @siddharthkp would love to hear any thoughts you might have on this approach for handling the |
…ed-for-the-actionlistlinkitem-components
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…ed-for-the-actionlistlinkitem-components
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…ed-for-the-actionlistlinkitem-components
green6erry
temporarily deployed
to
github-pages
GitHub Actions
Inactive
green6erry
deleted the
2411-the-aria-keyshortcuts-is-wrongly-attached-for-the-actionlistlinkitem-components
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 2411
Removes this disparity of
aria-keyshortcutsvalue, which when from mnemonics, was being assigned to the<li>wrapper of LinkItem, whereas if it wasaria-keyshortcutswas manually defined, it would assign to the inner<a>element (creating two keyboard shortcuts that looked like they were selecting the same element, but were not). This also applies the correct proprole="menuitem"to the<a>element instead of the<li>in Link Item.Screenshots
Previously, in this above example, pressing "u" would make the wrapper
<li>active, and "d" would make the inner<a>active. Now, "u" doesn't do anything as the mnemonic keyshortcut is overridden by the user defined "d".Changelog
Updated
aria-keyshortcutsto select the<a>tag withinrole="menuitem"is being assigned to correctly selectable DOM element inner<a>instead of the wrapper<li>Merge checklist