The aria-keyshortcuts is wrongly attached for the ActionList.LinkItem components

[jchuerva]

From https://github.com/github/repos/issues/3034

It looks like for ActionList.LinkItem component, the aria-keyshortcuts is attached the the <a> instead of <li> which is incorrect.

[lesliecdubs]

Thanks for reporting this bug, @jchuerva! This looks like it'll require a slightly more complex fix so we're moving it to our backlog for now but hope to revisit soon.

[siddharthkp]

Leaving here for context:

1. We need to move aria-keyshortcuts to the list item and also change the focusable element to list-item
2. After moving aria-keyshortcuts and focus, need to make sure the link can still be opened with keyboard

[green6erry]

Hey all, if we move the aria-keyshortcuts to the <li> element, it makes the selection the link wrapper and not the <a> element (because <li> in this case is a wrapper for the selectable item, <a>). It seems to me that to accomplish this requested assignment of the shortcut to the wrapper while keeping the functionality intact for the link is a bit roundabout thing to do. That said, to get further clarification:

• is this for the mnemonic key shortcut or a manually assigned key shortcut (or both)?
• why is attaching the aria-keyshortcuts to the <a> instead of <li> incorrect?

[lesliecdubs]

Good questions @green6erry! If you'd like an accessibility expert to weigh in on them, I'd suggest asking about this over in #accessibility on Slack or signing up for the next Accessibility Eng+ Office Hours for more hands-on support and advice.

This helpful accessibility guide may come in handy for your work!

[tallys]

hey @siddharthkp, checking in on this