Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes sx prop on the SegmentedControl buttons #2355

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

mperrotti
Copy link
Contributor

Properly merges the sx prop when cloning button children.

Closes #2286

@mperrotti mperrotti requested review from a team and siddharthkp September 20, 2022 17:57
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022

🦋 Changeset detected

Latest commit: 129f006

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 76.4 KB (+0.01% 🔺)
dist/browser.umd.js 77.05 KB (+0.01% 🔺)

@mperrotti mperrotti temporarily deployed to github-pages September 20, 2022 18:08 Inactive
@mperrotti mperrotti merged commit e052644 into main Sep 20, 2022
@mperrotti mperrotti deleted the mp/fix-segmented-control-sx-prop branch September 20, 2022 20:24
@primer-css primer-css mentioned this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SegmentedButton - sx props do not apply
2 participants