Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SegmentedButton - sx props do not apply #2286

Closed
lesliecdubs opened this issue Aug 29, 2022 · 3 comments · Fixed by #2355
Closed

SegmentedButton - sx props do not apply #2286

lesliecdubs opened this issue Aug 29, 2022 · 3 comments · Fixed by #2355
Assignees
Labels
bug Something isn't working react

Comments

@lesliecdubs
Copy link
Member

Describe the bug
As originally reported in #2267:

I'd like to be able to specify the SegmentedControl.Button as a small size as I can with other buttons
size is not a supported prop of SegmentedControl.Button - so I tried setting the fontSize through sx prop and it still has no effect.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://primer.style/react/SegmentedControl
  2. Note that size is not a supported prop for the Button
  3. Add sx={{fontSize: 0}} to one of the buttons
  4. Notice that nothing changes

Expected behavior
sx prop should apply to SegmentedControl.Button.

Screenshots
image

Desktop (please complete the following information):

  • OS: [e.g. iOS] MacOS
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22] 104
@mperrotti
Copy link
Contributor

Planning to work on this bug this week.

@lesliecdubs
Copy link
Member Author

lesliecdubs commented Sep 19, 2022

Thanks for the update @mperrotti! I moved this into "Up Next: Design" on the Primer teams backlog to match the status. I'd definitely focus on #2267 first, unless you'd rather the team handle this new size through the sx prop in the longer term.

@mperrotti
Copy link
Contributor

@lesliecdubs - I'd rather the team use the size prop. A PR has been merged to support the size prop: #2347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants