Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds size prop to the SegmentedControl #2347

Merged
merged 4 commits into from
Sep 19, 2022

Conversation

mperrotti
Copy link
Contributor

Adds a "small" size option to the SegmentedControl.

Closes #2267

Screenshots

Screen Shot 2022-09-19 at 2 27 27 PM

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and siddharthkp September 19, 2022 18:27
@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2022

🦋 Changeset detected

Latest commit: 1b29455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 76.39 KB (+0.07% 🔺)
dist/browser.umd.js 77.05 KB (+0.07% 🔺)

@mperrotti mperrotti temporarily deployed to github-pages September 19, 2022 18:34 Inactive
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 !

@mperrotti mperrotti merged commit 09a5d80 into main Sep 19, 2022
@mperrotti mperrotti deleted the mp/add-segmentedcontrol-size-variant branch September 19, 2022 18:42
@primer-css primer-css mentioned this pull request Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SegmentedButton - cannot specify size of the button
2 participants