Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add outline background and border color #1928

Merged
merged 4 commits into from
Mar 7, 2022
Merged

Conversation

pksjce
Copy link
Collaborator

@pksjce pksjce commented Mar 7, 2022

Describe your changes here.

The dark mode of outline button had the wrong background.

Before

image

After

image

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@pksjce pksjce requested review from a team and colebemis March 7, 2022 02:18
@changeset-bot
Copy link

changeset-bot bot commented Mar 7, 2022

🦋 Changeset detected

Latest commit: 40e961d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 64.31 KB (0%)
dist/browser.umd.js 64.67 KB (0%)

@pksjce pksjce merged commit 4dc15c3 into main Mar 7, 2022
@pksjce pksjce deleted the pk/outline-button-styles branch March 7, 2022 23:23
This was referenced Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants