-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tracking (next major) #1911
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* prepare integration branch * Move deprecated components to deprecated folder * Add subpath exports for deprecated * Fix up the docs * Remove dialog and formgroup components * Fix up all the tests * Create smooth-cameras-prove.md Co-authored-by: Reza Rahman <rezrah@github.com>
…#1883) * prefix component name to types * add changeset * Update .changeset/actionlist2-actionmenu2-prefix-types.md Co-authored-by: Cole Bemis <colebemis@github.com> Co-authored-by: Cole Bemis <colebemis@github.com>
* Export PageLayout from main bundle * Create odd-apes-guess.md * Add PageLayout to sidenav * Update .changeset/odd-apes-guess.md Co-authored-by: Rez <rezrah@github.com> * Update PageLayout docs Co-authored-by: Rez <rezrah@github.com>
…ropdown (#1887) * chore: add deprecation notices for SelectMenu and Dropdown * fix: deprecated metadata scope in docs * docs: update release notes for Flex and BorderBox * docs: update release notes for Position * chore: add deprecated scope to jsx snippets * chore: add release notes for Dropdown deprecation * chore: add Grid release notes * update release notes
* Deprecate ActionList v1 * Promote drafts/ActionList2 to main/ActionList * Add changelog * Undo package-lock change * update ActionList import for Menu2 docs * Deprecate ActionMenu - part 1 * Deprecate ActionMenu - part 2 * Promote drafts/ActionMenu2 to main/ActionMenu * Add changelog * Add @deprecated on deprecated/ActionMenu * docs fixed!
* Deprecate ActionList v1 * Promote drafts/ActionList2 to main/ActionList * Add changelog * Undo package-lock change * update ActionList import for Menu2 docs * changelog oopsie * fix docs copy * Add @deprecated on deprecated/ActionList * oopsie on the link * PR feedback on deprecation message
* Deprecate ActionList v1 * Promote drafts/ActionList2 to main/ActionList * Add changelog * Undo package-lock change * update ActionList import for Menu2 docs * Deprecate ActionMenu - part 1 * Deprecate ActionMenu - part 2 * Promote drafts/ActionMenu2 to main/ActionMenu * Add changelog * Add @deprecated on deprecated/ActionMenu * docs fixed! * reorder deprecated components alphabetically * Update deprecation message * Fix missing icon that only broke on this PR for some reason
* Deprecate ActionList v1 * Promote drafts/ActionList2 to main/ActionList * Add changelog * Undo package-lock change * update ActionList import for Menu2 docs * Deprecate ActionMenu - part 1 * Deprecate ActionMenu - part 2 * Promote drafts/ActionMenu2 to main/ActionMenu * Add changelog * Add @deprecated on deprecated/ActionMenu * docs fixed! * reorder deprecated components alphabetically * Update deprecation message * Fix missing icon that only broke on this PR for some reason * Deprecate DropdownMenu * Use deprecated Dropdown for theme switcher * Delete drafts/DropdownMenu2 * Add changelog * remove debug statement :)
size-limit report 📦
|
primer-css
force-pushed
the
changeset-release/next-major
branch
from
February 28, 2022 22:05
95a48a3
to
19ca837
Compare
primer-css
force-pushed
the
changeset-release/next-major
branch
from
February 28, 2022 22:23
19ca837
to
f9187a8
Compare
* Move old button to deprecated * Move Button2 to main bundle * Add migration docs * More changes from the checklist * More deprecation * Update tests * Add deprecated details * Create many-roses-hammer.md * Update .changeset/many-roses-hammer.md Co-authored-by: Rez <rezrah@github.com> * Update many-roses-hammer.md * Update many-roses-hammer.md * Update many-roses-hammer.md Co-authored-by: Rez <rezrah@github.com>
primer-css
force-pushed
the
changeset-release/next-major
branch
from
March 1, 2022 12:49
f9187a8
to
4b40d61
Compare
* add missing root exports * fix invalid export
primer-css
force-pushed
the
changeset-release/next-major
branch
from
March 9, 2022 12:26
6930220
to
a7837eb
Compare
primer-css
force-pushed
the
changeset-release/next-major
branch
from
March 9, 2022 12:27
a7837eb
to
bc5c574
Compare
primer-css
force-pushed
the
changeset-release/next-major
branch
from
March 9, 2022 12:27
bc5c574
to
f10bd63
Compare
primer-css
force-pushed
the
changeset-release/next-major
branch
from
March 9, 2022 13:24
f10bd63
to
c9cc207
Compare
primer-css
force-pushed
the
changeset-release/next-major
branch
from
March 9, 2022 17:55
c9cc207
to
24f015c
Compare
primer-css
force-pushed
the
changeset-release/next-major
branch
from
March 9, 2022 18:32
24f015c
to
99f3cdd
Compare
primer-css
force-pushed
the
changeset-release/next-major
branch
from
March 9, 2022 19:03
99f3cdd
to
06d6ace
Compare
primer-css
force-pushed
the
changeset-release/next-major
branch
from
March 9, 2022 19:37
06d6ace
to
1ed726e
Compare
primer-css
force-pushed
the
changeset-release/next-major
branch
from
March 9, 2022 19:41
1ed726e
to
da3872a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to next-major, this PR will be updated.
Releases
@primer/react@35.0.0
Major Changes
#1883
310e6553
Thanks @siddharthkp! -ActionList2
exported types are now prefixed withActionList
:ActionMenu2
exported types are now prefixed withActionMenu
:#1893
17ef5ef8
Thanks @siddharthkp! -ActionList
ActionList has been rewritten with a composable API, design updates and accessibility fixes.
See full list of props and examples: https://primer.style/react/ActionList
To continue to use the deprecated API for now, change the import path to
@primer/react/deprecated
:You can use the one-time codemod to change your import statements automatically.
#1897
d4023572
Thanks @siddharthkp! -ActionMenu
ActionMenu has been rewritten with a composable API, design updates and accessibility fixes.
See full list of props and examples: https://primer.style/react/ActionMenu
Main changes:
items
prop, useActionList
insideActionMenu
anchorContent
onActionMenu
, useActionMenu.Button
withchildren
onAction
prop onActionMenu
, useonSelect
prop onActionList.Item
groupMetadata
onActionMenu
, useActionList.Group
overlayProps
onActionMenu
, useActionMenu.Overlay
To continue to use the deprecated API for now, change the import path to
@primer/react/deprecated
:You can use the one-time codemod to change your import statements automatically.
#1898
d6d1ca4c
Thanks @siddharthkp! -DropdownMenu
DropdownMenu has been deprecated in favor of ActionMenu with ActionList
See example with selection: https://primer.style/react/ActionMenu#with-selection
Migration guide:
items
prop, useActionList
insideActionMenu
selectionVariant="single"
onActionList
to set the right semantics for selectionselectedItem
prop, useselected
prop onActionList.Item
renderAnchor
andplaceholder
props onDropdownMenu
, useActionMenu.Button
orActionMenu.Anchor
onChange
prop onDropdownMenu
, useonSelect
prop onActionList.Item
groupMetadata
onDropdownMenu
, useActionList.Group
overlayProps
onDropdownMenu
, useActionMenu.Overlay
To continue to use the deprecated API for now, change the import path to
@primer/react/deprecated
:You can use the one-time codemod to change your import statements automatically.
drafts/DropdownMenu2
DropdownMenu2 has been removed in favor of ActionMenu with ActionList
#1889
e9b81fae
Thanks @mperrotti! -Label
The Label component's API and visual design have been updated to be consistent with its counterpart in Primer ViewComponents' Label component.
Major changes in the new Label component:
medium
size - onlysmall
andlarge
outline
prop has been removedsx
propIf you were using the
Label
component to render issue/PR labels, use the IssueLabelToken component instead.To continue to use the deprecated API for now, change the import path to
@primer/react/deprecated
:You can use the one-time codemod to change your import statements automatically.
#1908
61404aed
Thanks @pksjce! -Button
Before
v35
,Button
was a set of seven independent components. Inv35
, we've simplified theButton
API.Button variants
We now support a variant property which takes values
primary
,invisible
,outline
anddanger
Leading and trailing icons
Previously including icons inside buttons required a lot of custom styling. In the new
Button
component, we now support first-classleadingIcon
andtrailingIcon
props:Icon buttons
Icon-only buttons are common in many applications. We now have a component designed for this use-case:
Size property
Previously, we used a
variant
prop to set the size of buttons. We now have a prop calledsize
which is more semantically correct.#1900
d61b28ad
Thanks @mperrotti! -ChoiceFieldset
The
CheckboxGroup
andRadioGroup
components are replacing theChoiceFieldset
component.CheckboxGroup
andRadioGroup
have the ability to render contextual content with your fieldset: labels, validation statuses, captions. They also handle the ARIA attributes that make the form controls accessible to assistive technology.To continue to use the deprecated API for now, change the import path to
@primer/react/deprecated
:You can use the one-time codemod to change your import statements automatically.
#1882
df757521
Thanks @colebemis! -PageLayout
PageLayout
is being graduated from thedrafts
bundle to themain
bundle.To upgrade, rewrite your imports accordingly:
#1888
f94dcd33
Thanks @mperrotti! -FormGroup, InputField, ChoiceInputField
The
FormControl
component is replacing theFormGroup
,InputField
, andChoiceInputField
components. It has the ability to render contextual content with your inputs: labels, validation statuses, captions. It also handles the ARIA attributes that make the form controls accessible to assistive technology.To continue to use the deprecated API for now, change the import path to
@primer/react/deprecated
:You can use the one-time codemod to change your import statements automatically.
#1881
8cd12439
Thanks @pksjce! -SelectMenu
SelectMenu
has been deprecated. Please useActionMenu
instead.See https://primer.style/react/ActionMenu for more migration examples.
Dropdown
Dropdown
has been deprecated. Please useActionMenu
instead.See https://primer.style/react/ActionMenu for more migration examples.
Flex
Flex
has been deprecated. Please useBox
instead.Grid
Grid
has been deprecated. Please useBox
instead.BorderBox
BorderBox
has been deprecated. Please useBox
instead.Position
Position
has been deprecated. Please useBox
instead.Minor Changes
561aad86
Thanks @siddharthkp! - Add align prop on ActionMenu.Overlay to pass through to AnchoredOverlayPatch Changes
#1922
b1d7b8c9
Thanks @siddharthkp! - ActionMenu.Button: Fix spacing between text and caret#1915
a98091c1
Thanks @siddharthkp! - - Update styles for default variant of Button's active state#1934
33da6a0e
Thanks @rezrah! - Surfaced the following components and hooks from the root index:These exports can now be imported from the root index, rather than from their nested subfolders.
E.g.