Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TextInputWithTokens to accept leading and trailing visuals #1886

Merged
merged 6 commits into from
Feb 25, 2022

Conversation

mperrotti
Copy link
Contributor

Makes it possible to render leading and trailing visuals in TextInputWithTokens just like we do in TextInput

Closes #1875

Screenshots

Screen Shot 2022-02-23 at 4 12 58 PM
Screen Shot 2022-02-23 at 4 13 12 PM

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@mperrotti mperrotti requested review from a team and colebemis February 23, 2022 21:15
@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2022

🦋 Changeset detected

Latest commit: b47f3d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2022

size-limit report 📦

Path Size
dist/browser.esm.js 64.24 KB (+0.1% 🔺)
dist/browser.umd.js 64.6 KB (+0.1% 🔺)

Copy link
Contributor

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Would be nice to get some examples in the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextInputWithTokens does not render leading/trailingVisual
2 participants