fix(ConfirmationDialog): use correct border radius on buttons #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b75fdc3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/7GJLt3W7d2PLjPFVzCNJSVANyrxs |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
Dialognow allows overflow (From #1203), the smaller border radius from thebuttons is overflowing past the larger border radius of the overlay, causing a different appearance in the header vs the footer. This change puts the same border radius on the buttons as what is used in the Dialog so that they matchSecond, the
ConfirmationDialogtitle had a hard-codedfont-weightof700. This likely came from the Overaly Prototype, but it is not the correct value. Switching tofontWeights.boldwhich is600.Closes #1239
Screenshots
Before
After
Merge checklist