fix: Don’t clip 'ConfirmationDialog' button outlines

[smockle]

Fixes https://github.com/github/primer/issues/129

Previously Dialog had overflow: hidden, which caused focus rings to clip. This PR removes overflow: hidden, then updates the border-radius of ConfirmationDialog buttons to follow the curvature of their container.

Before	After

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6923241

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/8vqXLpbL7zft9UKFqBeU34ovaQzM
✅ Preview: https://primer-components-git-confirmation-dialog-focus-ring-primer.vercel.app

[dgreif]

Nice fix, looks so much better!!

[dgreif]

Great coverage here for all cases except button:first-of-type:last-of-type if there is only 1 button. If we are assuming there will always be exactly 2 buttons, then this last section can be removed.

[smockle]

Oh interesting, great catch! I hadn’t considered a ConfirmationDialog with only one button. I’ll update this on Monday. 👍

[smockle]

Fixed in b2bdb66!

Before	After