-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background styles for focused action list item #1158
Conversation
🦋 Changeset detectedLatest commit: 2647438 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/GQV7e72mepwCA26ScBsbegfRcxwv |
23ccfc0
to
40813d3
Compare
40813d3
to
eea3bb7
Compare
eea3bb7
to
8ff3d48
Compare
8ff3d48
to
c5ad77f
Compare
Work in #1135 revealed that ActionListItems were not focusable, and when made focusable, their styling was not correct.
tabindex="-1"
.useFocusZone
will latch onto this and set the tab index to 0 when enabled.Closes #1180
Screenshots
Before
Gray is hover, outline is focused
After
Lighter is hover, darker is focus
Dark Mode
Dark Dimmed Mode
Merge checklist