Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DropdownMenu and ActionMenu focus styles need background colors #1180

Closed
dgreif opened this issue Apr 21, 2021 · 0 comments · Fixed by #1158
Closed

DropdownMenu and ActionMenu focus styles need background colors #1180

dgreif opened this issue Apr 21, 2021 · 0 comments · Fixed by #1158

Comments

@dgreif
Copy link
Member

dgreif commented Apr 21, 2021

Describe the bug
DropdownMenu and ActionMenu both use keyboard shortcuts to navigate their ActionList Items. When focused, these items currently use the browser default outline. They should instead be using specific background coloring to indicate focus vs hover and not have an outline.

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://primer.style/components/DropdownMenu
  2. Click on the demo dropdown
  3. Press the down key
  4. See outline instead of background color for focused item

Screenshots
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant