-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4 authoring #91
Conversation
If this is so simple, why haven't you done it already? |
This is added in the latest version of grunt-webfont. It allows us to rename the family name of the font that's ultimately generated. sapegin/grunt-webfont#338
@jonrohan How should we handle the jeykll plugin side of things? I think everything else in this PR is where it needs to be. |
Let's get the building and output setup, then what I'm thinking is we can then turn this repo also into a gem that will include octicons_helper as well as the jekyll plugin in a new pr. |
also, I'll probably need to research how most jekyll plugins are distributed, because gem might not be the way |
This PR is a work in progress. It'll be merged into #89 and makes a few changes on the authoring side of Octicons.
Internally, we currently have a web app that accepts SVG and builds a font based on a json file. What I'd rather see is the following workflow:
src
directoryThis PR is a step toward that. I did a small test with a couple Illustrator-generated SVGs and they seem to be working correctly.
Remaining tasks:
README
for accuracyWe need to make sure we have anThis is now possible with the latest version ofocticons-local.ttf
of the same specs as the current library for our internal Keynote documents.grunt-webfont
, but I'm not sure if it's completely necessary here.cc: @jonrohan