Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4 authoring #91

Merged
merged 20 commits into from
Jun 4, 2016
Merged

Version 4 authoring #91

merged 20 commits into from
Jun 4, 2016

Conversation

aaronshekey
Copy link
Contributor

@aaronshekey aaronshekey commented Apr 20, 2016

This PR is a work in progress. It'll be merged into #89 and makes a few changes on the authoring side of Octicons.

Internally, we currently have a web app that accepts SVG and builds a font based on a json file. What I'd rather see is the following workflow:

  1. An editable master Octicons Illustrator / Sketch file that exports raw SVG into the src directory
  2. Grunt then processes those SVGs using a minifier to strip them of all the authoring tools nonsense, handle rounding, etc.
  3. We build the fonts based on those processed SVGs

This PR is a step toward that. I did a small test with a couple Illustrator-generated SVGs and they seem to be working correctly.

Remaining tasks:

  • Kill the batman
  • Build a master sketch document with all the octicons
  • We should offer minified CSS to close Compression octicons.css to octicons.min.css #56
  • Offer a jekyll plugin to remove dependency on fonts
  • Update the README for accuracy
  • We need to make sure we have an octicons-local.ttf of the same specs as the current library for our internal Keynote documents. This is now possible with the latest version of grunt-webfont, but I'm not sure if it's completely necessary here.

cc: @jonrohan

@jonrohan
Copy link
Member

Kill the batman

If this is so simple, why haven't you done it already?

Aaron Shekey added 6 commits June 2, 2016 16:17
This is added in the latest version of grunt-webfont. It allows us to
rename the family name of the font that's ultimately generated.
sapegin/grunt-webfont#338
@aaronshekey
Copy link
Contributor Author

@jonrohan How should we handle the jeykll plugin side of things? I think everything else in this PR is where it needs to be.

@jonrohan
Copy link
Member

jonrohan commented Jun 3, 2016

How should we handle the jeykll plugin side of things?

Let's get the building and output setup, then what I'm thinking is we can then turn this repo also into a gem that will include octicons_helper as well as the jekyll plugin in a new pr.

@jonrohan
Copy link
Member

jonrohan commented Jun 3, 2016

as well as the jekyll plugin in a new pr.

also, I'll probably need to research how most jekyll plugins are distributed, because gem might not be the way

@jonrohan jonrohan merged commit 78ca3e8 into octicons-v4 Jun 4, 2016
@jonrohan jonrohan deleted the v4-authoring branch June 4, 2016 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants