-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating a grunt build system for octicons v4.0.0 #89
Conversation
@aaronshekey I have this working pretty well, but there's some weird hinting going on Plus here's a few more things I want to address
|
Yeah, that is rendering strangely. Some of the unicode symbols have changed between this and prior versions, right? That may be an issue, though I can't be sure how everyone's using Octicons. I'm not sure how high of a priority it is though. |
I haven't pulled down the code to see the full diff yet, but I'm seeing hella |
I pulled that directly from https://github.com/github/octicons.github.com in the interest of combining all the 3 repos for octicons. I would be into updating it to use a data map though. 👍 |
The beauty of a major update https://github.com/github/octicons#versions we're telling people it's breaking changes. |
With this build system, any additional symbol will be a breaking change, right? |
🙌 🙌 🙌 |
I guess so, but we can create a character code map to keep them similar. https://github.com/sapegin/grunt-webfont#codepoints |
I think this is similar to what Grunticon does, though they don't create a font. (Which is fine for our use internally, imo) I just got that up and running in a PR on the new help site and so far it is working great. |
@sophshep I think we may indeed want to keep the font around for local Keynote presentations and the like. I've added the pre-established codepoints, so we should be covered ✌️ |
Version 4 authoring
I'm going to merge this in, leaving the version at 3.5.0, not publishing anything new to npm. So I can do some testing in the github/github pipeline |
This is a WIP to create a grunt build system for octicons that will out put both font files and svg files.
The tl;dr of what I'm trying to do is:
src/svg
grunt
dist
@aaronshekey @github/css