Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a grunt build system for octicons v4.0.0 #89

Merged
merged 45 commits into from
Jun 6, 2016
Merged

Conversation

jonrohan
Copy link
Member

This is a WIP to create a grunt build system for octicons that will out put both font files and svg files.

The tl;dr of what I'm trying to do is:

  • SVG icon files will be placed in src/svg
  • The developer will run grunt
  • All assets are compiled to dist

@aaronshekey @github/css

@aaronshekey
Copy link
Contributor

Yes! This is super awesome and addresses #88 and #87.

@jonrohan jonrohan changed the title Creating a grunt build system for octicons Creating a grunt build system for octicons v4.0.0 Feb 15, 2016
@jonrohan jonrohan added this to the v4.0.0 milestone Feb 15, 2016
@jonrohan
Copy link
Member Author

@aaronshekey I have this working pretty well, but there's some weird hinting going on
image need to fine tune it.

Plus here's a few more things I want to address

@aaronshekey
Copy link
Contributor

Yeah, that is rendering strangely. Some of the unicode symbols have changed between this and prior versions, right? That may be an issue, though I can't be sure how everyone's using Octicons. I'm not sure how high of a priority it is though.

@mdo
Copy link

mdo commented Feb 16, 2016

I haven't pulled down the code to see the full diff yet, but I'm seeing hella _posts files. How performant is that looking vs something like a data file?

@jonrohan
Copy link
Member Author

but I'm seeing hella _posts files. How performant is that looking vs something like a data file?

I pulled that directly from https://github.com/github/octicons.github.com in the interest of combining all the 3 repos for octicons. I would be into updating it to use a data map though. 👍

@jonrohan
Copy link
Member Author

Some of the unicode symbols have changed between this and prior versions, right? That may be an issue

The beauty of a major update https://github.com/github/octicons#versions we're telling people it's breaking changes. 4.0.0

@aaronshekey
Copy link
Contributor

We're telling people it's breaking changes.

With this build system, any additional symbol will be a breaking change, right?

@mdo
Copy link

mdo commented Feb 16, 2016

major update [...] breaking changes

🙌 🙌 🙌

@jonrohan
Copy link
Member Author

With this build system, any additional symbol will be a breaking change, right?

I guess so, but we can create a character code map to keep them similar. https://github.com/sapegin/grunt-webfont#codepoints

@sophshep
Copy link

sophshep commented Apr 19, 2016

I think this is similar to what Grunticon does, though they don't create a font. (Which is fine for our use internally, imo)

I just got that up and running in a PR on the new help site and so far it is working great.

@aaronshekey
Copy link
Contributor

@sophshep I think we may indeed want to keep the font around for local Keynote presentations and the like. I've added the pre-established codepoints, so we should be covered ✌️

@aaronshekey aaronshekey mentioned this pull request Apr 20, 2016
6 tasks
@jonrohan
Copy link
Member Author

jonrohan commented Jun 6, 2016

I'm going to merge this in, leaving the version at 3.5.0, not publishing anything new to npm. So I can do some testing in the github/github pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants