Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 8.5.0 #299

Merged
merged 11 commits into from
Feb 27, 2019
Merged

Release 8.5.0 #299

merged 11 commits into from
Feb 27, 2019

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Feb 25, 2019 •
edited
Loading

Ship checklist

  • Update package.json with new version
  • Run npm run version to version the rest of the version packages.
  • Update Changelog

@jonrohan jonrohan self-assigned this Feb 25, 2019
jonrohan and others added 3 commits February 25, 2019 12:27
@jonrohan
Merge pull request #295 from primer/aria
3e15d9b 
Fix octicons_gem including aria-hidden when aria-label is present
Updated contributing guidelines
a9a3db9
@jonrohan
Merge pull request #300 from primer/update-contributing
1004aac 
Updated contributing guidelines
@jonrohan jonrohan changed the title [WIP] Release 8.5.0 Release 8.5.0 Feb 25, 2019
emilybrick
emilybrick approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@emilybrick emilybrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm. I'm not that familiar with the workflow/a11y stuff so it may be good to get a final review from @emplums or @shawnbot

emplums
emplums approved these changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@jonrohan jonrohan merged commit 6fe5475 into master Feb 27, 2019
@jonrohan jonrohan deleted the release-8.5.0 branch February 27, 2019 17:15
@jonrohan jonrohan mentioned this pull request Feb 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emplums emplums emplums approved these changes

@emilybrick emilybrick emilybrick approved these changes

Assignees

@jonrohan jonrohan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonrohan @emilybrick @emplums @muan