Fix octicons_gem including aria-hidden when aria-label is present #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorry about that. As it stands now, it requires setting up figma api keys to be able to build the data file locally. I'm hoping to add some extra to the code that will pull the last release file data.json if there's no figma api token in someone's env. Otherwise this looks like a good change! I can get it out next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Octicons gem should check for keys of both symbol and string types.
I was unable to run the test locally because it is looking for a mysterious
./build/data.jsonfile, and I can't find instructions for building one locally. 🤔