Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Skip import option to system props rule #21

Merged
merged 11 commits into from
Mar 22, 2023

Conversation

SferaDev
Copy link
Contributor

@SferaDev SferaDev commented Nov 25, 2021

  • Add skip import check
  • Auto-fix lint warnings
  • Add exclusions to CircleOcticon and Token

Signed-off-by: Alexis Rico <sferadev@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2021

🦋 Changeset detected

Latest commit: a89654d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-primer-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @SferaDev ❤️

@colebemis
Copy link
Contributor

@SferaDev Looks like there are some CI failures. Happy to merge this when those are fixed ✅

src/rules/no-system-props.js Outdated Show resolved Hide resolved
@colebemis colebemis merged commit 8041452 into primer:main Mar 22, 2023
This was referenced Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants