Update docs to match new major release breaking changes

[SferaDev]

Requires:

• Add Skip import option to system props rule eslint-plugin-primer-react#21

Changes:

• Use new rule on md/mdx code snippets
• Update docs with new rule changes and minor prettier updates

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

• Added/updated tests
• Added/updated documentation
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

⚠️ No Changeset found

Latest commit: ca7fff6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[SferaDev]

I noticed this for StyledOcticon but actually there're lots of outdated examples after #1639

[siddharthkp]

Yes! Love to see it

[SferaDev]

@siddharthkp Not sure if other props should be migrated, and/or if there's a linter rule to warn about this breaking change for the next major

[siddharthkp]

@SferaDev eslint-plugin-primer-react has a new release to go with the major version: https://github.com/primer/eslint-plugin-primer-react/releases

[colebemis]

Thank you ✨

[SferaDev]

@SferaDev eslint-plugin-primer-react has a new release to go with the major version: primer/eslint-plugin-primer-react/releases

The linter is not catching these, ie: the mr on the same file.

[SferaDev]

Created primer/eslint-plugin-primer-react#21 to allow the rule to be executed on the code snippets from docs folder.

cc: @jfuchs

[mperrotti]

@SferaDev - could we get the conflicts resolved so we can merge this?

[SferaDev]

Sure thing, will update tomorrow

[SferaDev]

@SferaDev - could we get the conflicts resolved so we can merge this?

Done! @mperrotti, however keep in mind that it requires primer/eslint-plugin-primer-react#21

Actually this PR is nothing else than running lint --fix and prettier with that fix to the eslint plugin

PS: I've reverted the changes for the files on the drafts folder, I guess they will need to be excluded on the plugin rule too, but not sure if the prop spec is finalized.

[github-actions]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.