Finish labelling Bank 0D #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bank 0D should be completely labelled, with the only "unlabelled" things being the undumped dummy "Function_cc000"s located before the move animation code. Also, many data groups and functions still need to be moved to their own files. Let me know if there's anything else not to your liking. |
|
CI builds; looks good enough for me. Not going to nitpick right now as we are dumping/labeling. Once we get to not needing a rom then I'll nitpick more. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're at the point where a fully labelled Bank 0D is just a hop and a skip away. Hopefully this pull request, when finished, will have labelled all functions that are either in or accessed from Bank 0D. Work has also been done to move certain data to separate files and have them INCLUDE-ed, to match pokegold.