fix(ci): Fix flaky test BroadcastTest.endToEndWithMultipleWriteNodes

[duxiao1212]

Summary:
X-link: #26461

Fix flaky stress test buck2 test //github/presto-trunk/presto-native-execution/presto_cpp/main/operators/tests:presto_operators_test -- 'BroadcastTest.endToEndWithMultipleWriteNodes/zstd' --stress-runs 100

BroadcastTestParam::TearDown() inherited from OperatorTestBase https://www.internalfb.com/code/fbsource/[37f968940832]/fbcode/velox/exec/tests/utils/OperatorTestBase.cpp?lines=153 ,

Added executor_.reset() to fix the flakness.

Task::addExchangeClientPool() creates leaf pool. BroadcastExchangeSource's async work on executor_ captures shared_ptr with buffers allocated from this pool. We need release the leaf pool before resetMemory to avoid arbitrary memory check failure.

The reference chain is: exchangeClient.0.0 [shared_ptr] → node.0 [shared_ptr] → query..2

Without the fix, the destructor of the leaf pool was handled asynchronously in another thread, so that exchangeClient.0.0 pool may be destroyed AFTER SharedArbitrator::shutdown(). executor_.reset() blocks and waits for all queued async work to complete, which includes the ExchangeSource cleanup that eventually destroys the exchangeClient.0.0 leaf pool. This ensures the pool hierarchy is fully cleaned up before OperatorTestBase::TearDown() runs SharedArbitrator::shutdown().

Reviewed By: xiaoxmeng

Differential Revision: D85685549

== NO RELEASE NOTE ==

Differential Revision: D85685549

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Injects a delay and lifecycle barrier in BroadcastTest teardown to resolve a race in async cleanup and tidies up argument formatting in executeBroadcastRead.

File-Level Changes

Change	Details	Files
Add asynchronous cleanup delay in BroadcastTest teardown	Override TearDown to call waitForAllTasksToBeDeleted() Insert std::this_thread::sleep_for(100ms) for async destructor completion Reset pool_ and rootPool_, and call resetMemory() in teardown	presto-native-execution/presto_cpp/main/operators/tests/BroadcastTest.cpp
Refactor executeBroadcastRead argument indentation	Align asRowType, tempDirectoryPath, and broadcastFilePaths by indenting two levels	presto-native-execution/presto_cpp/main/operators/tests/BroadcastTest.cpp

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}