You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: Fix flaky test BroadcastTest.endToEndWithMultipleWriteNodes (#26461)
Summary:
Fix flaky stress test buck2 test //github/presto-trunk/presto-native-execution/presto_cpp/main/operators/tests:presto_operators_test -- 'BroadcastTest.endToEndWithMultipleWriteNodes/zstd' --stress-runs 100
BroadcastTestParam::TearDown() inherited from OperatorTestBase https://www.internalfb.com/code/fbsource/[37f968940832]/fbcode/velox/exec/tests/utils/OperatorTestBase.cpp?lines=153 ,
We have an existing exchange source lifecycle protection for LocalExchangeSource https://fburl.com/code/aoz55crb. But our BroadcastTest..endToEndWithMultipleWriteNodes uses BroadcastExchangeSource which lacks this protection.
Since it's just a flaky test, the most straightforward way is just inject a latency to handle a race condition in async cleanup.
Differential Revision: D85685549
0 commit comments