-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session properties for scaled table scan configs to coordinator #24284
base: master
Are you sure you want to change the base?
Conversation
The change to the Java documentation should go together with this change to the coordinator. You can include your original patch to presto-docs/src/main/sphinx/presto_cpp/properties-session.rst in this PR. Logically, supposed the OSS community see this change and would like to look for more info, they could find the Java documentation in the codebase. Usually the files under presto-native-execution belong to the native C++ worker and are packaged and released together. Everything else belongs to the Java coordinator. |
We always have the Description section filled out. Other sections could be possibly skipped if not applicable. You can move your content under Motivation to Description. |
Thank you @natashasehgal for making the change! |
5340b2f
to
2daa462
Compare
When enabled, Presto will attempt to scale up table scans to improve performance. | ||
|
||
``native_table_scan_scale_up_memory_usage_ratio`` | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to make it the same length as line 432
Pls add to release notes. |
Description
Add session properties to Java coordinator for to scale table scan
Follow up: Add these parameters to Native workers #24275
Motivation and Context
Impact
Low impact
Test Plan
Contributor checklist
Release Notes
== NO RELEASE NOTE ==