Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the Include-What-You-Use for presto_cpp/main/common/ #24243

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adopt the Include-What-You-Use for presto_cpp/main/common/ #24243

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fae4eec
Include-What-You-Use and cmake fix for presto_cpp/main/common
anandamideShakyan Nov 27, 2024
33f28d8
Code refactor
anandamideShakyan Dec 13, 2024
e3f3e20
code refactor
anandamideShakyan Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code refactor
  • Loading branch information
@anandamideShakyan
anandamideShakyan committed Dec 13, 2024
commit 33f28d84df208c1f4a783f0222bdef4e91a3a24e
6 changes: 2 additions & 4 deletions presto-native-execution/presto_cpp/main/common/ConfigReader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,12 @@
*/

#include "presto_cpp/main/common/ConfigReader.h"

#include "velox/common/base/Exceptions.h"
#include "velox/common/config/Config.h"

#include <algorithm>
#include <cctype>
#include <fmt/format.h>
#include <fstream>
#include "velox/common/base/Exceptions.h"
#include "velox/common/config/Config.h"

namespace facebook::presto::util {

Expand Down
9 changes: 4 additions & 5 deletions presto-native-execution/presto_cpp/main/common/Configs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,17 @@
#include "presto_cpp/main/common/Configs.h"
#include "presto_cpp/main/common/ConfigReader.h"
#include "presto_cpp/main/common/Utils.h"
#include "velox/core/QueryConfig.h"

#include <boost/lexical_cast.hpp>
#include <boost/uuid/uuid_generators.hpp>
#include <boost/uuid/uuid_io.hpp>
#if __has_include("filesystem")
#include <filesystem>
namespace fs = std::filesystem;
#else
#include <experimental/filesystem>
namespace fs = std::experimental::filesystem;
#endif
#include <boost/lexical_cast.hpp>
#include <boost/uuid/uuid_generators.hpp>
#include <boost/uuid/uuid_io.hpp>
#include "velox/core/QueryConfig.h"

namespace facebook::presto {

Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/common/Utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
*/

#include "presto_cpp/main/common/Utils.h"
#include <fmt/format.h>
#include <sys/resource.h>
#include <fmt/format.h>
#include "velox/common/process/ThreadDebugInfo.h"

namespace facebook::presto::util {
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/common/tests/BaseVeloxQueryConfigTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
* limitations under the License.
*/
#include "presto_cpp/main/common/Configs.h"
#include <gtest/gtest.h>
#include "velox/common/base/Exceptions.h"
#include "velox/common/file/File.h"
#include "velox/common/file/FileSystems.h"
#include "velox/core/QueryConfig.h"
#include <gtest/gtest.h>

namespace facebook::presto::test {

Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/common/tests/CommonTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
*/
#include "presto_cpp/main/common/Exception.h"
#include "presto_cpp/main/common/Utils.h"
#include "velox/common/base/Exceptions.h"
#include <gtest/gtest.h>
#include "velox/common/base/Exceptions.h"

using namespace facebook::velox;
using namespace facebook::presto;
Expand Down
2 changes: 1 addition & 1 deletion presto-native-execution/presto_cpp/main/common/tests/ConfigTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@
*/
#include "presto_cpp/main/common/ConfigReader.h"
#include "presto_cpp/main/common/Configs.h"
#include <gtest/gtest.h>
#include "velox/common/base/Exceptions.h"
#include "velox/common/base/tests/GTestUtils.h"
#include "velox/common/file/File.h"
#include "velox/common/file/FileSystems.h"
#include <gtest/gtest.h>

namespace facebook::presto::test {

Expand Down
Loading