Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the Include-What-You-Use for presto_cpp/main/common/ #24243

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

anandamideShakyan
Copy link
Contributor

@anandamideShakyan anandamideShakyan commented Dec 11, 2024

Description

Adopt the Include-What
Propose to 1) adopt Include-What-You-Use (IWYU) for header files, and 2) link what-you-use in CMakeList.

Motivation and Context

Screenshot 2024-12-11 at 10 05 23 PM

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

@anandamideShakyan anandamideShakyan requested a review from a team as a code owner December 11, 2024 20:10
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Dec 11, 2024
@prestodb-ci prestodb-ci requested review from a team, ScrapCodes and imsayari404 and removed request for a team December 11, 2024 20:10
@anandamideShakyan anandamideShakyan changed the title Adopt the Include-What-You-Use Adopt the Include-What-You-Use for presto_cpp/main/common/ Dec 13, 2024
presto_common_BaseVeloxQueryConfigTest
presto_common_ConfigReader
presto_common_Configs
${RE2}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants