Upgrade Esri to 2.2.4 #15200
Merged
Upgrade Esri to 2.2.4 #15200
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbasmanova
approved these changes
Sep 22, 2020
|
[test-facebook] |
|
Upgrade changed some union results; I'll look into it and fix. |
This includes several fixes, two that affect our users that we reported: Esri/geometry-api-java#247 Esri/geometry-api-java#266 The second, in particular, caused workers to hang when they tried to perform a union of two geometries. Release notes: https://github.com/Esri/geometry-api-java/releases/tag/v2.2.4
jagill
force-pushed
the
hung-intersection
branch
from
9115f84 to
7555929
Compare
|
[test-facebook] |
1 similar comment
|
[test-facebook] |
This was referenced Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several fixes, two that affect our users that we reported:
Esri/geometry-api-java#247
Esri/geometry-api-java#266
The second, in particular, caused workers to hang when they tried to
perform a union of two geometries.
Release notes:
https://github.com/Esri/geometry-api-java/releases/tag/v2.2.4
Test plan - (Please fill in how you tested your changes)
Added test case that reproduces the hang. It does not hang anymore!
depended by https://github.com/facebookexternal/presto-facebook/pull/1182