Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple geometry reported as non-simple #247

Closed
jagill opened this issue Nov 20, 2019 · 2 comments
Closed

Simple geometry reported as non-simple #247

jagill opened this issue Nov 20, 2019 · 2 comments
Assignees
Milestone

Comments

@jagill
Copy link

jagill commented Nov 20, 2019

We have many multilinestrings like the one below, which are "tadpole" shapes with a loop and a tail. As a linestring they are invalid, but can be made valid by breaking them up into three line strings: two for the loop, and one for the tail, all intersecting only at boundary points.

Inspecting the multilinestring shows that it is simple. However, Esri reports it as non-simple: it fails at the checkCracking_() at OperatorSimplifyLocalHelper.isSimplePlanarImpl_ line 127.

String wkt = "MULTILINESTRING ((-103.4894322 25.6164519, -103.4889647 25.6159054, -103.489434 25.615654), (-103.489434 25.615654, -103.4894322 25.6164519), (-103.4897361 25.6168342, -103.4894322 25.6164519))";
OGCGeometry ogcGeom = OGCGeometry.fromText(wkt);
assert(ogcGeom.isSimple()); // This fails!
@jagill
Copy link
Author

jagill commented Nov 20, 2019

cc @vladgp

@stolstov
Copy link
Member

@jagill I'll take a look

@stolstov stolstov added this to the 2.2.4 milestone Nov 24, 2019
@alocke alocke self-assigned this Jan 23, 2020
jagill added a commit to jagill/presto that referenced this issue Sep 23, 2020
This includes several fixes, two that affect our users that we reported:
Esri/geometry-api-java#247
Esri/geometry-api-java#266

The second, in particular, caused workers to hang when they tried to
perform a union of two geometries.

Release notes:
https://github.com/Esri/geometry-api-java/releases/tag/v2.2.4
arhimondr pushed a commit to prestodb/presto that referenced this issue Sep 28, 2020
This includes several fixes, two that affect our users that we reported:
Esri/geometry-api-java#247
Esri/geometry-api-java#266

The second, in particular, caused workers to hang when they tried to
perform a union of two geometries.

Release notes:
https://github.com/Esri/geometry-api-java/releases/tag/v2.2.4
@alocke alocke closed this as completed Oct 8, 2020
shangxinli pushed a commit to shangxinli/presto that referenced this issue Nov 18, 2020
This includes several fixes, two that affect our users that we reported:
Esri/geometry-api-java#247
Esri/geometry-api-java#266

The second, in particular, caused workers to hang when they tried to
perform a union of two geometries.

Release notes:
https://github.com/Esri/geometry-api-java/releases/tag/v2.2.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants