fix(types): changed extended firebase instance to function #743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge prescottprue:Next into rscotten:next
…en/react-redux-firebase into fix-ExtendedFirebaseInstance-type2
|
@prescottprue I accidentally branched off |
Codecov Report
@@ Coverage Diff @@
## next #743 +/- ##
=======================================
Coverage 82.86% 82.86%
=======================================
Files 30 30
Lines 969 969
Branches 177 177
=======================================
Hits 803 803
Misses 166 166 |
|
I made another type fix to logout and prettier formatted the whole file. I tried running |
prescottprue
changed the title
prescottprue
added a commit
that referenced
this pull request
Aug 11, 2019
* feat(hooks): hook rework to match existing HOC - #734 - @illuminist * fix(hooks): remove create functions (`createUseFirestore`, `createWithFirestore`, `createUseFirebase`, `createWithFirebase`) since store selection is not necessary * feat(auth): add custom claims - #741 - @joerex * fix(types): changed extended firebase instance to function - #743 - @rscotten * fix(types): switch `typeof Firebase` to `any` (prevents issue with passing some version of Firebase JS SDK) * fix(examples): update material and typescript examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a small type error on
ExtendedFirebaseInstancefromfirestore: ExtendedFirestoreInstanceto
and also fixes the return type of the
logoutfunction fromto
Check List
If not relevant to pull request, check off as complete
Relevant Issues