feat(auth): add custom claims #741
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(docs): make examples of HOCs more consistent * fix(examples): update react-native example to use expo * fix(examples): update example deps
From comment here: prescottprue#344 (comment)
it is not true by default
…th to.be.undefined and to.equal(true) with to.be.true
|
@joerex It looks like you forgot to (re)base your commits on the next branch. There are loads of commits included that aren't yours and 163 changed files in total. |
|
@joerex your changes look great, nice work! If we point it to |
|
Used |
prescottprue
added a commit
that referenced
this pull request
Aug 11, 2019
* feat(hooks): hook rework to match existing HOC - #734 - @illuminist * fix(hooks): remove create functions (`createUseFirestore`, `createWithFirestore`, `createUseFirebase`, `createWithFirebase`) since store selection is not necessary * feat(auth): add custom claims - #741 - @joerex * fix(types): changed extended firebase instance to function - #743 - @rscotten * fix(types): switch `typeof Firebase` to `any` (prevents issue with passing some version of Firebase JS SDK) * fix(examples): update material and typescript examples
prescottprue
pushed a commit
that referenced
this pull request
Aug 11, 2019
|
Also added to a PR for v2.4.0 so it can go into latest. Thanks again @joerex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Firebase has a secure way of identifying and making claims about users with custom claims. This is a good way to provide roles for users.
This PR offers an optional configuration to fetch custom claims with the profile and updates the docs to describe how to do it.
Check List
If not relevant to pull request, check off as complete
Relevant Issues