Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OmniOS CI job #2406

Merged
merged 1 commit into from
Jan 1, 2025
Merged

Add OmniOS CI job #2406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions .github/workflows/ci-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,6 +326,44 @@ jobs:
with:
name: premake-solaris-${{ matrix.platform }}
path: bin/${{ matrix.config }}/
omnios:
runs-on: ubuntu-latest
strategy:
matrix:
config: [debug, release]
platform: [x64]
cc: [gcc]
timeout-minutes: 30
defaults:
run:
shell: omnios {0}
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Start OmniOS VM
uses: vmactions/omnios-vm@v1
with:
usesh: true
prepare: |
pkg install build-essential web/ca-bundle
- name: Build
run: |
cd $GITHUB_WORKSPACE
CC=${{ matrix.cc }} PLATFORM=${{ matrix.platform }} CONFIG=${{ matrix.config }} PREMAKE_OPTS="--cc=${{ matrix.cc }}" ./Bootstrap.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are both CC=${{ matrix.cc }} and "--cc=${{ matrix.cc }}" required?
Some jobs have both, some don't.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copy-pasted, but yes it is required sometimes.

CC is for Bootstrap.mak. Some of these systems don't have cc set to anything, so we need to specify via CC.
--cc is for Premake. Really only required when using Clang, but not really worth removing.

- name: Test
run: |
cd $GITHUB_WORKSPACE
bin/${{ matrix.config }}/premake5 test --test-all
- name: Docs check
run: |
cd $GITHUB_WORKSPACE
bin/${{ matrix.config }}/premake5 docs-check
- name: Upload Artifacts
if: matrix.config == 'release' && matrix.cc == 'gcc'
uses: actions/upload-artifact@v4
with:
name: premake-omnios-${{ matrix.platform }}
path: bin/${{ matrix.config }}/

# This job will be required for PRs to be merged.
# This should depend on (via needs) all jobs that need to be successful for the PR to be merged.
Expand Down
1 change: 1 addition & 0 deletions contrib/curl/premake5.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ project "curl-lib"
"/usr/local/share/certs/ca-root-nss.crt",
"/etc/certs/ca-certificates.crt",
"/etc/ssl/cert.pem",
"/etc/ssl/cacert.pem",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it part of this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's where the web/ca-bundle package installed the CA certs.

"/boot/system/data/ssl/CARootCertificates.pem" } do
if os.isfile(f) then
ca = f
Expand Down
Loading