Add OmniOS CI job #2406
Merged
Add OmniOS CI job #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarod42
approved these changes
Jan 1, 2025
| - name: Build | ||
| run: | | ||
| cd $GITHUB_WORKSPACE | ||
| CC=${{ matrix.cc }} PLATFORM=${{ matrix.platform }} CONFIG=${{ matrix.config }} PREMAKE_OPTS="--cc=${{ matrix.cc }}" ./Bootstrap.sh |
There was a problem hiding this comment.
Are both CC=${{ matrix.cc }} and "--cc=${{ matrix.cc }}" required?
Some jobs have both, some don't.
There was a problem hiding this comment.
This is copy-pasted, but yes it is required sometimes.
CC is for Bootstrap.mak. Some of these systems don't have cc set to anything, so we need to specify via CC.
--cc is for Premake. Really only required when using Clang, but not really worth removing.
| @@ -45,6 +45,7 @@ project "curl-lib" | |||
| "/usr/local/share/certs/ca-root-nss.crt", | |||
| "/etc/certs/ca-certificates.crt", | |||
| "/etc/ssl/cert.pem", | |||
| "/etc/ssl/cacert.pem", | |||
There was a problem hiding this comment.
Yes, that's where the web/ca-bundle package installed the CA certs.
nickclark2016
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds OmniOS CI job. Fixes #2387
How does this PR change Premake's behavior?
N/A
Anything else we should know?
N/A
Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!