Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement mirror and oci settings #988

Merged
merged 11 commits into from
Mar 19, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Mar 15, 2024

This also updates the toml crate because I ran cargo update. Apparently Document is deprecated in favor of DocumentMut.

@pavelzw
Copy link
Contributor

pavelzw commented Mar 16, 2024

Closes #172

docs/advanced/global_configuration.md Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
docs/advanced/global_configuration.md Outdated Show resolved Hide resolved
docs/advanced/global_configuration.md Outdated Show resolved Hide resolved
docs/advanced/global_configuration.md Outdated Show resolved Hide resolved
@pavelzw
Copy link
Contributor

pavelzw commented Mar 19, 2024

could we also add a info or debug message that tells you which mirror you are using in the end?

@ruben-arts
Copy link
Contributor

ruben-arts commented Mar 19, 2024

Testing the examples in the documentation still gives me:

ERROR rattler_repodata_gateway::fetch: error=Request error: HTTP status client error (401 Unauthorized) for url (https://prefix.dev/conda-forge/osx-arm64/repodata.json.zst)
  × failed to fetch repodata from channels
  ├─▶ Request error: HTTP status client error (401 Unauthorized) for url (https://prefix.dev/conda-forge/osx-arm64/repodata.json.zst)
  ╰─▶ HTTP status client error (401 Unauthorized) for url (https://prefix.dev/conda-forge/osx-arm64/repodata.json.zst)

Not sure it is because the website doesn't work or because of the mirror.

Edit: This bug was happening because I didn't have a working token. This is however not correct as it shouldn't error on a broken token while accessing a public channel. @baszalmstra is onto it.

@ruben-arts ruben-arts enabled auto-merge (squash) March 19, 2024 16:00
@ruben-arts ruben-arts merged commit ec4ff23 into prefix-dev:main Mar 19, 2024
7 of 8 checks passed
Comment on lines +59 to +61
no_jlap: false,
no_bz2: false,
no_zstd: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be dependent on the config?

Copy link
Contributor

@pavelzw pavelzw Mar 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nvm this should be done in #1015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants