Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wire up global config for jlap / zstd and bzip2 support in repodata #1015

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Mar 19, 2024

No description provided.

@wolfv wolfv changed the title wire up global config for jlap / zstd and bzip2 support in repodata feat: wire up global config for jlap / zstd and bzip2 support in repodata Mar 19, 2024
Copy link
Contributor

@ruben-arts ruben-arts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add these options to the documentation?

src/config.rs Outdated Show resolved Hide resolved
@pavelzw
Copy link
Contributor

pavelzw commented Mar 20, 2024

Do you still need to set the options in reqwest.rs? #988 (comment)

@wolfv
Copy link
Member Author

wolfv commented Mar 20, 2024

@pavelzw we still need to set them to conform to the mirror settings. We are now setting the global options at a "higher" level which will not make requests for jlap etc. at all.

If we set them in the mirror settings, then the mirror will unconditionally reply with 404 to the requests in the middleware.

@wolfv wolfv enabled auto-merge (squash) March 20, 2024 10:27
src/config.rs Outdated Show resolved Hide resolved
@ruben-arts ruben-arts merged commit 8de97fb into prefix-dev:main Mar 20, 2024
17 checks passed
@wolfv wolfv deleted the repodata_options branch March 20, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants