Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: UNICORN #1719
New Adapter: UNICORN #1719
Changes from 19 commits
b699f42
956aa91
9bdb44b
0515c28
36ae31f
ec49639
725321d
003e27d
95844a4
ca3026a
285c5d7
f1c2427
42ae15a
019800d
7be6aa9
8b9dcd1
f067fac
8cb4906
74b363a
3b1f698
1080b56
435bf6e
c27da8b
fb58a7e
deaf6c0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that there's a scenario where
ext.Bidder.PlacementID
does not get modified at all makes for an opportunity to maybe refactor theif-else
statement in line 138 to maybe something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly, fixed it. Thanks you.
deaf6c0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem to not be doing anything with
imp
which is a modified copy of the ith element of[]Imp
. Did we mean to add it to, say amodifiedImps
array?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No,
modifyImps
is rewriting imp to include the required data.For example, it is implemented to put
placementId
orstoredRequestImpId
forImp[i].TagID
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh you are right. Misread line 126 as a local copy of the imp (
imp := *request.Imp[i]
) instead ofimp := &request.Imp[i]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
true
branch of thisif
statement is not covered in the tests cases. Could we add a native JSON test that covers it?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native will support it in the future, so I left it, but since it is not currently supported, I will remove this branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed it
deaf6c0