Fix review problem

prebid · Mar 3, 2021 · deaf6c0 · deaf6c0
1 parent fb58a7e
commit deaf6c0
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/adapters/unicorn/unicorn.go b/adapters/unicorn/unicorn.go
@@ -134,20 +134,15 @@ func modifyImps(request *openrtb.BidRequest) error {
 			}
 		}
 
-		var placementID string
-		if ext.Bidder.PlacementID != "" {
-			placementID = ext.Bidder.PlacementID
-		} else {
-			placementID, err = getStoredRequestImpID(imp)
+		if ext.Bidder.PlacementID == "" {
+			ext.Bidder.PlacementID, err = getStoredRequestImpID(imp)
 			if err != nil {
 				return &errortypes.BadInput{
 					Message: fmt.Sprintf("Error get StoredRequestImpID from imp[%d]: %s", i, err),
 				}
 			}
 		}
 
-		ext.Bidder.PlacementID = placementID
-
 		imp.Ext, err = json.Marshal(ext)
 		if err != nil {
 			return &errortypes.BadInput{
@@ -157,7 +152,7 @@ func modifyImps(request *openrtb.BidRequest) error {
 
 		secure := int8(1)
 		imp.Secure = &secure
-		imp.TagID = placementID
+		imp.TagID = ext.Bidder.PlacementID
 	}
 	return nil
 }
@@ -235,8 +230,6 @@ func (a *adapter) MakeBids(request *openrtb.BidRequest, requestData *adapters.Re
 				if imp.ID == bid.ImpID {
 					if imp.Banner != nil {
 						bidType = openrtb_ext.BidTypeBanner
-					} else if imp.Native != nil {
-						bidType = openrtb_ext.BidTypeNative
 					}
 				}
 			}