Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOL Bid Adapter: Remove validation of bidder specific video params for Nexage endpoint call formation #6766

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

patmmccann
Copy link
Collaborator

@patmmccann patmmccann commented May 14, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This brings the AOL adapter into compliance with 5.0 requirement outlined at #6512

AOL is welcome to recommit these validations to function from either mediatypes.video or their own parameters; however they have said they are planning to deprecate this adapter altogether in other threads and also the onevideo adapter is where they concentrate their video demand. It isn't actually clear if this adapter still functions for video demand, but it seems unlikely to for long if it does now.

Additionally, their documentation makes no mention of Video support at https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/aol.md or any other place.

@patmmccann
Copy link
Collaborator Author

FYI @slimkrazy

@lgtm-com
Copy link

lgtm-com bot commented May 14, 2021

This pull request introduces 1 alert and fixes 2 when merging 82709a8 into 05f86d7 - view on LGTM.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 1 for Identical operands
  • 1 for Useless conditional

@ChrisHuie ChrisHuie self-requested a review May 17, 2021 12:58
@ChrisHuie ChrisHuie requested review from ChrisHuie and removed request for ChrisHuie May 18, 2021 11:45
@ChrisHuie ChrisHuie added major and removed minor labels May 21, 2021
@patmmccann
Copy link
Collaborator Author

@ChrisHuie test issues appear unrelated, looking for a merge on this

@ChrisHuie ChrisHuie merged commit 3be28d1 into prebid-5.0 Jun 4, 2021
@ChrisHuie ChrisHuie deleted the aol-prebid-5-change branch June 4, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants