Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digitrust exit - 4.0 branch #5416

Conversation

patmmccann
Copy link
Collaborator

This simply opens #5334 on the 4.0 branch

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goosemanjack ,

gulp test is failing on test/spec/modules/pubmaticBidAdapter_spec.js:1360:44. Can you ensure the command passes? Also, it shows a merge conflict on modules/userId/eids.js. It'll be great if you can resolve that as well.

@pm-harshad-mane
Copy link
Contributor

Hello @Fawke ,
I downloaded the code for the PR and ran gulp test, i do not see issues with it.

@pm-harshad-mane
Copy link
Contributor

Can we update the PR branch code with upstream/master? i see old code of PubMatic adapter present in it.

@pm-harshad-mane
Copy link
Contributor

I have raised a PR to remove the DigiTrust related test case from PubMatic bidder, #5426

@Fawke
Copy link
Contributor

Fawke commented Jun 29, 2020

@pm-harshad-mane Thanks for removing the test case. I've updated the prebid-4.0 branch with the changes from master. I've to close this PR in favor of #5429, because I can't resolve the merge conflict in modules/userId/eids.js.

5249 resolves this merge conflict.

@Fawke Fawke closed this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants