-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digitrust exit - 4.0 branch #5416
Digitrust exit - 4.0 branch #5416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gulp test
is failing on test/spec/modules/pubmaticBidAdapter_spec.js:1360:44
. Can you ensure the command passes? Also, it shows a merge conflict on modules/userId/eids.js
. It'll be great if you can resolve that as well.
Hello @Fawke , |
Can we update the PR branch code with |
I have raised a PR to remove the DigiTrust related test case from PubMatic bidder, #5426 |
@pm-harshad-mane Thanks for removing the test case. I've updated the prebid-4.0 branch with the changes from master. I've to close this PR in favor of #5429, because I can't resolve the merge conflict in 5249 resolves this merge conflict. |
This simply opens #5334 on the 4.0 branch