-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digitrust Disable from ID System #5334
Digitrust Disable from ID System #5334
Conversation
Hi, What about removing digitrust from adapters and prebid docs? Is your plan that publishers upgrading prebid would de-integrate automatically? Thanks! |
I have a separate and as-yet unsubmitted PR that covers those items. I wanted to keep mucking with everyone's adapters out of this to limit chance of issues. |
Would you rather commit against the 4.0 branch? Publishers that upgrade minor versions might consider this a breaking change. 4.0 release rather imminent |
I'm going to have to get back to you after consulting some internal people. Being that any of the user Ids are optional for any publisher, this should not be breaking. I do, however, see your point. If I were to commit against 4.0, which branch should I look at? |
@goosemanjack Here is Prebid 4.0 branch https://github.com/prebid/Prebid.js/tree/prebid-4.0 |
I will submit a PR to the 4.0 branch, probably later this week, and will also submit a separate PR to remove it from all adapters using the external ID mechanics for DigiTrust. I encourage this PR to also be accepted. The underlying endpoint for DigiTrust is going to be turned off in the near future. By my review, not accepting this PR will cause exceptions due to a dead ID request. Since all external IDs are opt-in by the publisher site, once this is merged the adapter behavior should be the same as if DigiTrust is not included by the publisher - namely the ID will be ignored instead of causing a failed attempt. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Touching. Will try to find time this week. |
Hey Chris, your commit was already merged on the 4.0 branch, you can close this pr, and hopefully open the adapters and docs pr. Thanks! |
Thanks. |
We are evaluating some deep changes to the way DigiTrust ID operates given changes in the market and in browsers. While this work is underway we want to limit any additional integrations with DigiTrust that might break when new changes roll out.
Type of change
Description of change
This PR removes all references to the DigiTrust ID system from the UserID system in Prebid. A separate PR will be submitted that touches individual bidder adapters that may have taken an integration dependency.
Other information