Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide more data in Adhese bid response #5154

Merged
merged 13 commits into from
Apr 28, 2020
Merged

Provide more data in Adhese bid response #5154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a1391f1
Add support for bidderRequest.refererInfo in Adhese Adapter.
mefjush Apr 8, 2019
bde66ca
Merge remote-tracking branch 'origin/mastermastermaster'
Apr 11, 2019
c72f234
Add support for bidderRequest.refererInfo in Adhese Adapter.
mefjush Apr 8, 2019
6611cff
Merge branch 'master' of github.com:adhese/Prebid.js
mefjush Apr 30, 2019
d7e9483
Jira AD-2462 / add tlall is consent string is present
Oct 22, 2019
0da5c59
Added 'adhese' attribute to bid that contains meta data - Jira AD-2642
Oct 23, 2019
3045d68
added DALE to adhese determination
Oct 23, 2019
e0a6d7c
extra config option: no format, but use size array as format string
Oct 23, 2019
57f0033
Added more values to originData
Apr 20, 2020
1c367df
Revert "Added more values to originData"
Apr 20, 2020
7b8db87
Pulled Sander's changes & added more data to originData
Apr 20, 2020
5a32f50
Merge remote-tracking branch 'prebid/master'
sander-adhese Apr 21, 2020
1134474
Adhese bid adapter - final version
Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion modules/adheseBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,11 +170,15 @@ function getAdDetails(ad) {
if (isAdheseAd(ad)) {
creativeId = ad.id;
dealId = ad.orderId;
originData = { priority: ad.priority, orderProperty: ad.orderProperty, adFormat: ad.adFormat, adType: ad.adType, libId: ad.libId, adspaceId: ad.adspaceId, viewableImpressionCounter: ad.viewableImpressionCounter };
originData = { priority: ad.priority, orderProperty: ad.orderProperty, adFormat: ad.adFormat, adType: ad.adType, libId: ad.libId, adspaceId: ad.adspaceId, viewableImpressionCounter: ad.viewableImpressionCounter, slotId: ad.slotID, slotName: ad.slotName, advertiserId: ad.advertiserId, adId: ad.id };
} else {
creativeId = ad.origin + (ad.originInstance ? '-' + ad.originInstance : '');
if (ad.originData) {
originData = ad.originData;
originData.slotId = ad.slotID;
originData.slotName = ad.slotName;
originData.adType = ad.adType;
if (ad.adFormat) originData.adFormat = ad.adFormat;
if (ad.originData.seatbid && ad.originData.seatbid.length) {
const seatbid = ad.originData.seatbid[0];
if (seatbid.bid && seatbid.bid.length) {
Expand Down
18 changes: 15 additions & 3 deletions test/spec/modules/adheseBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ describe('AdheseAdapter', function () {
origin: 'APPNEXUS',
originInstance: '',
ext: 'js',
slotID: '10',
slotName: '_main_page_-leaderboard',
adType: 'leaderboard',
originData: {
Expand Down Expand Up @@ -155,12 +156,15 @@ describe('AdheseAdapter', function () {
ttl: TTL,
adhese: {
originData: {
adType: 'leaderboard',
seatbid: [
{
bid: [ { crid: '60613369', dealid: null } ],
seat: '958'
}
]
],
slotId: '10',
slotName: '_main_page_-leaderboard'
}
}
}];
Expand Down Expand Up @@ -249,12 +253,16 @@ describe('AdheseAdapter', function () {
adhese: {
originData: {
adFormat: 'largeleaderboard',
adId: '742898',
adType: 'largeleaderboard',
adspaceId: '162363',
libId: '90511',
orderProperty: undefined,
priority: undefined,
viewableImpressionCounter: undefined
viewableImpressionCounter: undefined,
slotId: '29306',
slotName: '_main_page_-leaderboard',
advertiserId: '2081'
}
},
cpm: 5.96,
Expand Down Expand Up @@ -304,12 +312,16 @@ describe('AdheseAdapter', function () {
adhese: {
originData: {
adFormat: '',
adId: '742470',
adType: 'preroll',
adspaceId: '164196',
libId: '89860',
orderProperty: undefined,
priority: undefined,
viewableImpressionCounter: undefined
viewableImpressionCounter: undefined,
slotId: '41711',
slotName: '_main_page_-leaderboard',
advertiserId: '2263',
}
},
cpm: 0,
Expand Down