Provide more data in Adhese bid response #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 57f0033.
|
Hi, is there any reason why the review is taking longer than expected? |
jimee02
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Jun 12, 2020
* Add support for bidderRequest.refererInfo in Adhese Adapter. * Add support for bidderRequest.refererInfo in Adhese Adapter. * Jira AD-2462 / add tlall is consent string is present * Added 'adhese' attribute to bid that contains meta data - Jira AD-2642 * added DALE to adhese determination * extra config option: no format, but use size array as format string * Added more values to originData * Revert "Added more values to originData" This reverts commit 57f0033. * Pulled Sander's changes & added more data to originData * Adhese bid adapter - final version Co-authored-by: Mateusz Michalowski <mateusz@adhese.eu> Co-authored-by: Mateusz Michalowski <mateusz@michalowski.biz> Co-authored-by: Tim Sturtewagen <tim@adhese.com> Co-authored-by: Kim Van Crombrugge <kim@adhese.eu> Co-authored-by: Sander <sander@adhese.eu>
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* Add support for bidderRequest.refererInfo in Adhese Adapter. * Add support for bidderRequest.refererInfo in Adhese Adapter. * Jira AD-2462 / add tlall is consent string is present * Added 'adhese' attribute to bid that contains meta data - Jira AD-2642 * added DALE to adhese determination * extra config option: no format, but use size array as format string * Added more values to originData * Revert "Added more values to originData" This reverts commit 57f0033. * Pulled Sander's changes & added more data to originData * Adhese bid adapter - final version Co-authored-by: Mateusz Michalowski <mateusz@adhese.eu> Co-authored-by: Mateusz Michalowski <mateusz@michalowski.biz> Co-authored-by: Tim Sturtewagen <tim@adhese.com> Co-authored-by: Kim Van Crombrugge <kim@adhese.eu> Co-authored-by: Sander <sander@adhese.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update to provide more Adhese related data in the bid response. Doesn't have any affect on running implementations.
Updated the tests to reflect the changes in the adapter.
contact email of the adapter’s maintainer: support@adhese.eu
official adapter submission
Other information