Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset GPT targeting for custom div ids #5132

Merged

Conversation

FilipStamenkovic
Copy link
Contributor

Type of change

  • Bugfix

Description of change

When resetting targeting provide customSlotMatching function (that is also used for setting gpt targeting).
Right now, code is checking whether it should reset targeting: if adUnit code is the same as gpt slot adUnit path or if adUnit code is the same as div id. If all these checks fail, use customSlotMatching function as fallback to determine if targeting should be reset.

Other information

This PR is addressing #5131 issue.

@harpere harpere added the needs 2nd review Core module updates require two approvals from the core team label Apr 17, 2020
@jaiminpanchal27 jaiminpanchal27 merged commit 916b1a6 into prebid:master Apr 22, 2020
banesto pushed a commit to banesto/Prebid.js that referenced this pull request Apr 27, 2020
* commit '8db2720d60a6533dee52e96f847854ef1c219345': (249 commits)
  Release 3.17.0
  LunaMedia Adapter (prebid#5110)
  UserId module to export user ids as eids with pbjs.getUserIdsAsEids() (prebid#5108)
  Triplelift: expose tl_souce in bid response (prebid#5139)
  Add warning messages for publishers while native ads send assets containing url without sendId  (prebid#5096)
  use customSlotMatching func for reseting targeting (prebid#5132)
  Teads fix production GDPR error (prebid#5122)
  No bid version 1.2.5 (prebid#5137)
  SublimeBidAdapter src/url.js import fix (prebid#5150)
  Improve Digital adapter: add support for outstream video (prebid#5129)
  Disallowing remote requests from Safari and Firefox due to browsers no longer supporting DigiTrust ID. (prebid#5109)
  PS bid adapter update to copy site object from config (prebid#5083)
  SublimeBidAdapter: Update to version 0.5.1 (prebid#4977)
  LuponMedia Bid Adapter (prebid#5146)
  [BUGFIX] AdagioBidAdapter getDataFromLocalStorage (prebid#5081)
  Revert "New LuponMedia Bid Adapter (prebid#5120)" (prebid#5145)
  New LuponMedia Bid Adapter (prebid#5120)
  Feature/send publisher domain (prebid#5121)
  update test adunit params (prebid#5135)
  add parameter to the conversant adapter to override the url (prebid#5133)
  ...
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
@FilipStamenkovic FilipStamenkovic deleted the reset_gpt_targeting_custom_divs branch November 18, 2021 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants