Add warning messages for publishers while native ads send assets containing url without sendId

[bmwcmw]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Following the updated documentation, we want to drop a warning to tell that sendid is mandatory for all fields receiving URLs, notably: product images, clickUrl, logoimage

• test parameters for validating bids

pbjs.addAdUnits([{
    ...
    mediaTypes: {
        native: {
            image: {
                required: true,
                sendId: false //false to see the warning
            },
            icon: {
                required: true,
                sendId: false
            },
            clickUrl: {
                required: true,
                sendId: false
            },
            displayUrl: {
                required: true,
                sendId: false
            },
            privacyLink: {
                required: true,
                sendId: false
            },
            privacyIcon: {
                required: true,
                sendId: false
            }
            //other assets will not trigger the warning
        }
    },     
...

[bmwcmw]

Hi @jsnellbaker @robertrmartinez, I'd like to know is there any blocking point for this? Many thanks :)

[robertrmartinez]

Hi @bmwcmw I have not had a chance to take a look at this yet but will do so soon.

Usually we recommend adding a test for any PR to make sure we do not lag behind on the required 80% coverage for each adapter. So if you could please add an associated test for this change that would be great!

[bmwcmw]

Thank you @robertrmartinez , just added a unit test on it

[robertrmartinez]

Not sure the change does what is intended.

Can you please point out if I am missing something?

[robertrmartinez]

I am not sure this ever will run the checkNativeSendId function?

On line 266 you are explicitly setting hasNativeSendId to true which means it will always short circuit in this OR operator and not run the checkNativeSendId.

Am I missing something?

[bmwcmw]

It's updated with improved tests, thanks for the pointing out.

[robertrmartinez]

Cool stuff!

Thanks for the patience!