Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename playgroundxyz adapter #4918

Merged
merged 4 commits into from
Mar 5, 2020
Merged

Rename playgroundxyz adapter #4918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d43009
renames playgroundxyz bid adapter to pxyz
monofonik Mar 2, 2020
d67c57f
remove redundant pxyz alias
monofonik Mar 2, 2020
33e52f9
adds comment explaining reason for alias
monofonik Mar 2, 2020
2e8a238
update bidder code in test parameters
monofonik Mar 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions modules/playgroundxyzBidAdapter.js → modules/pxyzBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,17 @@ import { registerBidder } from '../src/adapters/bidderFactory.js';
import { BANNER } from '../src/mediaTypes.js';
import * as utils from '../src/utils.js';

const BIDDER_CODE = 'playgroundxyz';
const BIDDER_CODE = 'pxyz';
const URL = 'https://ads.playground.xyz/host-config/prebid?v=2';
const DEFAULT_CURRENCY = 'USD';

export const spec = {
code: BIDDER_CODE,
aliases: ['playgroundxyz', 'pxyz'],

// This adapter was previously named playgroundxyz - this alias ensures
// backwards compatibility for publishers
aliases: ['playgroundxyz'],

supportedMediaTypes: [BANNER],

/**
Expand Down
2 changes: 1 addition & 1 deletion modules/playgroundxyzBidAdapter.md → modules/pxyzBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ var adUnits = [
},
sizes: [[300, 250]],
bids: [{
bidder: 'playgroundxyz',
bidder: 'pxyz',
params: {
placementId: '13473562'
}
Expand Down
10 changes: 5 additions & 5 deletions ...c/modules/playgroundxyzBidAdapter_spec.js → test/spec/modules/pxyzBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { expect } from 'chai';
import { spec } from 'modules/playgroundxyzBidAdapter.js';
import { spec } from 'modules/pxyzBidAdapter.js';
import { newBidder } from 'src/adapters/bidderFactory.js';
import { deepClone } from 'src/utils.js';

Expand All @@ -12,7 +12,7 @@ const BIDDER_REQUEST = {
}
};

describe('playgroundxyzBidAdapter', function () {
describe('pxyzBidAdapter', function () {
const adapter = newBidder(spec);

describe('inherited functions', function () {
Expand All @@ -23,7 +23,7 @@ describe('playgroundxyzBidAdapter', function () {

describe('isBidRequestValid', function () {
let bid = {
'bidder': 'playgroundxyz',
'bidder': 'pxyz',
'params': {
'placementId': '10433394'
},
Expand Down Expand Up @@ -51,7 +51,7 @@ describe('playgroundxyzBidAdapter', function () {
describe('buildRequests', function () {
let bidRequests = [
{
'bidder': 'playgroundxyz',
'bidder': 'pxyz',
'params': {
'placementId': '10433394'
},
Expand Down Expand Up @@ -176,7 +176,7 @@ describe('playgroundxyzBidAdapter', function () {
};

let bidderRequest = {
'bidderCode': 'playgroundxyz'
'bidderCode': 'pxyz'
};

it('should get correct bid response', function () {
Expand Down