Rename playgroundxyz adapter #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
approved these changes
Mar 5, 2020
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
* renames playgroundxyz bid adapter to pxyz * remove redundant pxyz alias * adds comment explaining reason for alias * update bidder code in test parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
For some time we've been recommending publishers configure the
playgroundxyzadapter using the aliaspxyz. This reduces the chance of publisher DFP configuration errors resulting from string truncation / character limits.A recent change to the user sync module prevents our user sync pixel from firing on publishers using the
pxyzalias, even when the aliased adapter is the only configured instance of the Playground XYZ adapter.This PR renames the
playgroundxyzbidder topxyz. This will ensure we can both avoid the DFP truncation issues AND still fire our user sync pixel reliably. Backwards compatibility for any publishers using theplaygroundxyzbidder code is ensured by the retention of aplaygroundxyzalias.Other information
Related PR for the documentation is here: prebid/prebid.github.io#1828