Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename playgroundxyz adapter #4918

Merged
merged 4 commits into from
Mar 5, 2020

Conversation

monofonik
Copy link
Contributor

@monofonik monofonik commented Mar 2, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other - adapter name change

Description of change

For some time we've been recommending publishers configure the playgroundxyz adapter using the alias pxyz. This reduces the chance of publisher DFP configuration errors resulting from string truncation / character limits.

A recent change to the user sync module prevents our user sync pixel from firing on publishers using the pxyz alias, even when the aliased adapter is the only configured instance of the Playground XYZ adapter.

This PR renames the playgroundxyz bidder to pxyz. This will ensure we can both avoid the DFP truncation issues AND still fire our user sync pixel reliably. Backwards compatibility for any publishers using the playgroundxyz bidder code is ensured by the retention of a playgroundxyz alias.

Other information

Related PR for the documentation is here: prebid/prebid.github.io#1828

@harpere harpere added the LGTM label Mar 5, 2020
@harpere harpere merged commit dbaea4f into prebid:master Mar 5, 2020
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* renames playgroundxyz bid adapter to pxyz

* remove redundant pxyz alias

* adds comment explaining reason for alias

* update bidder code in test parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants